Skip to content

[Backport] Add/update newsletter messages in translation file#19118

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
arnoudhgz:2.2-develop-PR-port-19050
Nov 12, 2018
Merged

[Backport] Add/update newsletter messages in translation file#19118
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
arnoudhgz:2.2-develop-PR-port-19050

Conversation

@arnoudhgz
Copy link
Contributor

@arnoudhgz arnoudhgz commented Nov 8, 2018

Original Pull Request

#19050
Original PR: #18932 (was closed by me because of out-of-sync fork)

Description (*)

The messages in the Newsletter module were update, but the messages in the translation files have been forgotten.

When using translation tools it is mandatory to have correct strings in the i18n files. This pull request aims to solve this.

Manual testing scenarios (*)

Compare the messages in app/code/Magento/Newsletter/Controller/Manage/Save.php with the i18n file

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Component: Newsletter Release Line: 2.2 labels Nov 8, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 8, 2018

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@arnoudhgz
Copy link
Contributor Author

arnoudhgz commented Nov 8, 2018

I know it is a cleanup, but we really need these translations in 2.2 👍

@orlangur orlangur self-assigned this Nov 8, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 8, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 8, 2018

Hi @orlangur, thank you for the review.
ENGCOM-3414 has been created to process this Pull Request

@orlangur
Copy link
Contributor

orlangur commented Nov 8, 2018

@arnoudhgz I would rather treat it as a bug - inability to localize something is a severe issue.

@VladimirZaets VladimirZaets self-assigned this Nov 8, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 8, 2018

Hi @VladimirZaets, thank you for the review.
ENGCOM-3414 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 740f9d2 into magento:2.2-develop Nov 12, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 12, 2018
ENGCOM-3414: [Backport] Add/update newsletter messages in translation…
a934881 
… file #19118
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 12, 2018

Hi @arnoudhgz. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlangur orlangur orlangur approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@orlangur orlangur

@VladimirZaets VladimirZaets

Labels

Cleanup Component: Newsletter Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.8

Development

Successfully merging this pull request may close these issues.

4 participants

@arnoudhgz @magento-engcom-team @orlangur @VladimirZaets